Fix abbreviate weekday name. #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might fix #298 |
Yeah, that solves that issue. |
lb-
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks @ACK1D this works well for new data but did not work well for existing bakerydemo installations.
I have added migration functions and will push to your branch.
https://docs.djangoproject.com/en/5.0/ref/migration-operations/#runpython
def forwards_func(apps, schema_editor):
OperatingHours = apps.get_model("locations", "locationoperatinghours")
db_alias = schema_editor.connection.alias
OperatingHours.objects.using(db_alias).filter(day="TUES").update(day="TUE")
OperatingHours.objects.using(db_alias).filter(day="THUR").update(day="THU")
def reverse_func(apps, schema_editor):
OperatingHours = apps.get_model("locations", "locationoperatinghours")
db_alias = schema_editor.connection.alias
OperatingHours.objects.using(db_alias).filter(day="TUE").update(day="TUES")
OperatingHours.objects.using(db_alias).filter(day="THU").update(day="THUR")
# ...
operations = [
migrations.RunPython(forwards_func, reverse_func), # added here
migrations.AlterField(
model_name="locationoperatinghours",
# ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strftime("%a") expects a three letter abbreviation, so in current implementation two locations per week are closed.